Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skin aggregation task #219

Open
jgribonvald opened this issue Sep 25, 2018 · 1 comment
Open

Add skin aggregation task #219

jgribonvald opened this issue Sep 25, 2018 · 1 comment

Comments

@jgribonvald
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The skin aggregation script like implemented in uPortal project is missing here for custom skins if we want to use them in a static way.
i.e. only the portlet aggregator can provide an aggregated skin as the skin.aggr.xml is provided from default skin and isn't builded with customizations.
Due to that we can't include into a skin some custom js (we need to load them from a portlet), they are only included into the skin.xml and not into skin.aggr.xml.
On an other way the system property to disable aggregation don't work anymore (due to systme property not read for this property + property name changed at one place and not on lib dependency about the aggregation

Describe the solution you'd like

  • Implements the skin aggregation script
  • Reactivate the skin aggregation property use
@jgribonvald
Copy link
Contributor Author

solved by #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants