Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find replacement for secrets.yml as it's deprecated #3347

Open
murny opened this issue Jan 18, 2024 · 2 comments
Open

Find replacement for secrets.yml as it's deprecated #3347

murny opened this issue Jan 18, 2024 · 2 comments

Comments

@murny
Copy link
Contributor

murny commented Jan 18, 2024

From recent #3346 we are now getting the following deprecation warning:

DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2.

We should maybe move to credentials? But this requires a potential organizational shift as Jupiter would hold all the secrets and not Ansible, and we will use a MASTER_KEY to decrypt it.

https://edgeguides.rubyonrails.org/security.html#custom-credentials

@murny
Copy link
Contributor Author

murny commented Mar 9, 2024

Perhaps we could just use a simple config_for? https://api.rubyonrails.org/classes/Rails/Application.html#method-i-config_for

This will get around the deprecation but keep everything else the same (could also let us rename secrets to something else too)

@pgwillia
Copy link
Member

pgwillia commented May 6, 2024

We won't fix it. Jupiter will be decommissioned in January 2025 after moving to Scholaris, the national repository of DSpace instances hosted by Scholars Portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants