Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support typscript in vue-country-flag-next #72

Closed
micm0 opened this issue Jun 7, 2021 · 3 comments
Closed

Support typscript in vue-country-flag-next #72

micm0 opened this issue Jun 7, 2021 · 3 comments

Comments

@micm0
Copy link

micm0 commented Jun 7, 2021

I'm using the next library in a Vue 3 project with Typescript. When I import the library with import CountryFlag from 'vue-country-flag-next'; I get this error Cannot find module 'vue-country-flag-next' or its corresponding type declarations.

I created a new file vue-country-flag-next.d.ts in my project with declare module 'vue-country-flag-next'; as a workaround but It could be nice to support typing :D

@micm0 micm0 changed the title Support typings in vue-country-flag-next Support typscript in vue-country-flag-next Jun 7, 2021
@ubaldop
Copy link
Owner

ubaldop commented Jun 10, 2021

Thank you for reporting this! I will add typings.

@itapingu
Copy link

When you think this will be added? Causing some pain when testing stuff that require your component inside jest :) will be really appreciate if you add the declaration.

@ubaldop ubaldop mentioned this issue Nov 22, 2021
@ubaldop
Copy link
Owner

ubaldop commented Nov 22, 2021

@micm0 @itapingu latest 2.3.1 should fix the issue. Thanks for reporting this!

@ubaldop ubaldop closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants