Fix how Parsoid checks domain name

[kitsook]

MW 1.35 has a new Parsoid implemented in PHP. When preparing the upgrade, we added a hack to get around a domain check issue.

mediawiki-docker/Dockerfile

Line 58 in 8d2a56d

COPY ParsoidHandler_custom_1_35.php /var/www/html/vendor/wikimedia/parsoid/extension/src/Rest/Handler/ParsoidHandler.php

The change uses environment var PARSOID_SKIP_DOAMIN_CHECK to decide if it should skip the domain name check in Parsoid:

mediawiki-docker/ParsoidHandler_custom_1_35.php

Lines 251 to 254 in 8d2a56d

	// FIXME custom env variable PARSOID_SKIP_DOAMIN_CHECK to skip the check
	if ( empty( $this->parsoidSettings['debugApi'] ) && ! filter_var( getenv( 'PARSOID_SKIP_DOAMIN_CHECK' ), FILTER_VALIDATE_BOOLEAN ) ) {
	$this->assertDomainIsCorrect( $attribs['envOptions']['domain'] );
	}

Why we needed the hack: in our setup, we use Apache to redirect calls to restbase and domain name is hard-coded as localhost, causing the domain name check to fail.

mediawiki-docker/mediawiki.conf

Lines 30 to 31 in 8d2a56d

	ProxyPass /api/rest_v1 ${RESTBASE_URL}/localhost/v1 nocanon
	ProxyPassReverse /api/rest_v1 ${RESTBASE_URL}/localhost/v1 nocanon

Note that the domain check function itself is provisional.

mediawiki-docker/ParsoidHandler_custom_1_35.php

Lines 136 to 140 in 8d2a56d

	protected function assertDomainIsCorrect( $domain ): void {
	// We are cutting some corners here (IDN, non-ASCII casing)
	// since domain name support is provisional.
	// TODO use a proper validator instead
	$wgServer = \RequestContext::getMain()->getConfig()->get( 'Server' );

Reference: 9741576