Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http server, before request, should start a new request context #60

Open
spellr opened this issue Aug 12, 2018 · 1 comment
Open

http server, before request, should start a new request context #60

spellr opened this issue Aug 12, 2018 · 1 comment

Comments

@spellr
Copy link

spellr commented Aug 12, 2018

Right now the server can use RequestContextManager to create a new context when it get a request. That way, the context's span will be used by the http clients it uses and the trace will be passed to the servers that it calls. But no reason it won't happen in http_server's before_request.

That way, when a server sends request to another server using an http client, the same trace of the incoming request will be used by the next servers, and the server doesn't need to create the context itself.

@yurishkuro
Copy link
Contributor

RequestContextManager is going to be deprecated once PR #54 is merged.

I am not sure what exactly you're proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants