Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zapslog: Move to root Zap module #1270

Open
Tracked by #1333
galecore opened this issue Apr 9, 2023 · 7 comments
Open
Tracked by #1333

zapslog: Move to root Zap module #1270

galecore opened this issue Apr 9, 2023 · 7 comments

Comments

@galecore
Copy link

galecore commented Apr 9, 2023

Hello, Uber Zap team and community!

Fellow gophers might know that the proposal on https://pkg.go.dev/golang.org/x/exp/slog was accepted, and slog will soon appear in the standard library.

I wrote an extension library for slog handlers, and a handler for zap is in it! I would greatly appreciate your feedback on the code - https://github.com/galecore/xslog

I hope that Uber Zap team would also be interested in probably re-using this code in the future, when slog will become a staple of logging for golang applications.

Let me know what you think,

Tim

@sywhang
Copy link
Contributor

sywhang commented Apr 11, 2023

Hey @galecore!

Thanks for raising this issue. I took a cursory look at your library and we have something similar already. Check out https://github.com/uber-go/zap/tree/master/exp/zapslog from #1246 :)

@AlekSi
Copy link
Contributor

AlekSi commented Jun 30, 2023

It seems that there is some license problem: https://pkg.go.dev/go.uber.org/zap/exp@v0.0.0-20230508154324-382e2511e51c/zapslog

@jba
Copy link

jba commented Aug 2, 2023

Hi Zap team, slog author here. Go 1.21 will be out soon, and log/slog will be in it. I would love it if you could give some attention to zapslog to make sure it works with the latest version of slog (at a minimum, changing the import path).

And what do you think about moving it out of your exp tree into some place more permanent/official?

@sywhang
Copy link
Contributor

sywhang commented Aug 3, 2023

Hello @jba , master branch currently tracks latest version of slog with #1314 and #1315.

Once Go 1.21 is out, we can consider moving it out of exp/ tree to the top-level package.

@vvakame
Copy link

vvakame commented Aug 16, 2023

Go 1.21 was out! 🎉

@AlekSi
Copy link
Contributor

AlekSi commented Aug 22, 2023

And the blog post about slog is out too: https://go.dev/blog/slog

@abhinav abhinav changed the title Using zap as backend via slog.Handler for the upcoming slog logging library zapslog: Move to root Zap module Aug 23, 2023
@abhinav
Copy link
Collaborator

abhinav commented Aug 23, 2023

Turning this into an issue to move zapslog out of exp.
I've created #1333 to track what remains for zapslog to be stabilized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants