AddCaller() with JSON output

[maticmeznar]

I used to be able to use AddCaller() with JSON output, but since updating Zap, I cannot. Is it ever going to be added back? If yes, when? If no, whats the last version of Zap where it still worked?

Error:
cannot use zap.AddCaller() (type zap.Option) as type zap.JSONOption in argument to zap.NewJSONEncoder

[jdknezek]

I think the issue is that AddCaller() is an Option for a Logger, whereas you're trying to add it as a JSONOption to a JSONEncoder. You should change:

logger := zap.New(zap.NewJSONEncoder(zap.AddCaller()))

to

logger := zap.New(zap.NewJSONEncoder(), zap.AddCaller())

[akshayjshah]

@jdknezek is correct - AddCaller is an option for the logger, not the encoder. Be aware that AddCaller is a bit broken at the moment, and may be removed in the future (see #40).

[maticmeznar]

My bad, thank you!