Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSpecify: Use @NullMarked instead of -XepOpt:NullAway:AnnotatedPackages #1042

Closed
pemistahl opened this issue Sep 17, 2024 · 3 comments
Closed

Comments

@pemistahl
Copy link

While testing the JSpecify annotations with NullAway, I thought I would be able to remove the -XepOpt:NullAway:AnnotatedPackages setting in favor of using the @NullMarked annotation. I want to specify the code to be checked on class level instead of package level. This does not seem to be possible right now. Setting the @NullMarked annotation does not have any effect. However, when I remove the AnnotatedPackages setting NullAway even fails to initialize at all.

Will this be fixed in a future release to provide conformity with the JSpecify specification?

@beatbrot
Copy link

Just a sidenote: I think both variants should work at the same time.
In my codebase, it is not feasable to add NullMarked everywhere, therefore I enjoyed using NullAway:AnnotatedPackages. I want to keep doing this :)

@msridhar
Copy link
Collaborator

Thanks for the feedback! We have an open issue on this, #574. Let's continue the discussion there.

@msridhar
Copy link
Collaborator

Duplicate of #574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants