Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing (timeout) on Go 1.12 #31

Open
dansimau opened this issue Apr 17, 2019 · 0 comments
Open

Test failing (timeout) on Go 1.12 #31

dansimau opened this issue Apr 17, 2019 · 0 comments

Comments

@dansimau
Copy link
Contributor

dansimau commented Apr 17, 2019

Seems to be flaky but always happens on TestProjectPlanDetachSuccess.

$ make test
go test -timeout 1m -coverprofile=.coverage.out ./... \
		|grep -v -E '^\?'
ok  	github.com/uber/astro/astro	4.705s	coverage: 77.8% of statements
ok  	github.com/uber/astro/astro/cli/astro/cmd	0.617s	coverage: 82.1% of statements
ok  	github.com/uber/astro/astro/exec2	0.056s	coverage: 89.6% of statements
ok  	github.com/uber/astro/astro/terraform	0.043s	coverage: 25.4% of statements
coverage: 86.5% of statements
panic: test timed out after 1m0s

goroutine 353 [running]:
testing.(*M).startAlarm.func1()
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:1334 +0xdf
created by time.goFunc
	/usr/local/Cellar/go/1.12.1/libexec/src/time/sleep.go:169 +0x44

goroutine 1 [chan receive]:
testing.(*T).Run(0xc000490800, 0x14edb3f, 0x1c, 0x1502668, 0x107ef01)
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:917 +0x381
testing.runTests.func1(0xc000190000)
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:1157 +0x78
testing.tRunner(0xc000190000, 0xc000145df8)
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:865 +0xc0
testing.runTests(0xc0000c2680, 0x18a3f20, 0x5, 0x5, 0x0)
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:1155 +0x2a9
testing.(*M).Run(0xc000134200, 0x0)
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:1072 +0x162
main.main()
	_testmain.go:98 +0x1cb

goroutine 359 [chan receive]:
testing.(*T).Run(0xc0002bf800, 0x14e4a04, 0x6, 0xc0000b8dd0, 0xc0003c0f01)
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:917 +0x381
github.com/uber/astro/astro/tests.TestProjectPlanDetachSuccess(0xc000490800)
	/Users/dan/.go/src/github.com/uber/astro/astro/tests/integration_test.go:106 +0xee
testing.tRunner(0xc000490800, 0x1502668)
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:865 +0xc0
created by testing.(*T).Run
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:916 +0x35a

goroutine 400 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus(0xc0002c8370, 0xc00028a540, 0xc00028a5a0, 0x0, 0xc000390170)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:51 +0x93
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).runPlan(0xc0002c8370, 0xc00030b900, 0xc0003900e0, 0x0, 0x1, 0x0, 0x0)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/cmd.go:283 +0x306
github.com/spf13/cobra.(*Command).execute(0xc00030b900, 0xc000390060, 0x1, 0x1, 0xc00030b900, 0xc000390060)
	/Users/dan/.go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:762 +0x465
github.com/spf13/cobra.(*Command).ExecuteC(0xc00030b400, 0xa, 0xc0001f8240, 0x0)
	/Users/dan/.go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:852 +0x2ec
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/dan/.go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:800
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).Run(0xc0002c8370, 0xc0000c2360, 0x2, 0x2, 0x0)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/cmd.go:134 +0x1d1
github.com/uber/astro/astro/tests.RunTest(0xc0002bf800, 0xc0000c2360, 0x2, 0x2, 0x14e9eab, 0x14, 0x14e4a04, 0x6, 0x0)
	/Users/dan/.go/src/github.com/uber/astro/astro/tests/base.go:134 +0x657
github.com/uber/astro/astro/tests.TestProjectPlanDetachSuccess.func1(0xc0002bf800)
	/Users/dan/.go/src/github.com/uber/astro/astro/tests/integration_test.go:113 +0x160
testing.tRunner(0xc0002bf800, 0xc0000b8dd0)
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:865 +0xc0
created by testing.(*T).Run
	/usr/local/Cellar/go/1.12.1/libexec/src/testing/testing.go:916 +0x35a

goroutine 35 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0000d2580, 0xc0001e0240)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 67 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0000d28f0, 0xc0000b4300)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 207 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc00014e580, 0xc0004128a0)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 87 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0000d2e70, 0xc000399260)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 72 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0000d2b00, 0xc0000b4840)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 78 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0000d2420, 0xc00028a1e0)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 135 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0003b4000, 0xc00028ac60)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 221 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0000d2630, 0xc0001e16e0)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 150 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0000d29a0, 0xc0001e1a40)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 125 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc00014e160, 0xc0004db560)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 249 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0002c8790, 0xc0004db1a0)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 195 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0002c80b0, 0xc000097260)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 338 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0003b46e0, 0xc00028a240)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 177 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0002c8160, 0xc0004da660)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 214 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc000130160, 0xc0001e0d80)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 204 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0002c82c0, 0xc000412240)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 308 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0002c86e0, 0xc0000b4a80)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 387 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc00014e370, 0xc0001e1560)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 278 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0003b4210, 0xc000097500)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 343 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0003b49a0, 0xc00028ae40)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 300 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc00014e0b0, 0xc0001e0480)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 441 [IO wait]:
internal/poll.runtime_pollWait(0x1d1a008, 0x72, 0xffffffffffffffff)
	/usr/local/Cellar/go/1.12.1/libexec/src/runtime/netpoll.go:182 +0x56
internal/poll.(*pollDesc).wait(0xc000097398, 0x72, 0x8001, 0x8000, 0xffffffffffffffff)
	/usr/local/Cellar/go/1.12.1/libexec/src/internal/poll/fd_poll_runtime.go:87 +0x9b
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/Cellar/go/1.12.1/libexec/src/internal/poll/fd_poll_runtime.go:92
internal/poll.(*FD).Read(0xc000097380, 0xc00027e000, 0x8000, 0x8000, 0x0, 0x0, 0x0)
	/usr/local/Cellar/go/1.12.1/libexec/src/internal/poll/fd_unix.go:169 +0x1f2
os.(*File).read(...)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/file_unix.go:263
os.(*File).Read(0xc00020a1d8, 0xc00027e000, 0x8000, 0x8000, 0x0, 0xc0003bf700, 0x1041079)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/file.go:108 +0x70
io.copyBuffer(0x1581800, 0xc0004fcd20, 0x1581b60, 0xc00020a1d8, 0xc00027e000, 0x8000, 0x8000, 0x0, 0x1502cd8, 0xc0001fca80)
	/usr/local/Cellar/go/1.12.1/libexec/src/io/io.go:402 +0x122
io.Copy(...)
	/usr/local/Cellar/go/1.12.1/libexec/src/io/io.go:364
os/exec.(*Cmd).writerDescriptor.func1(0x1, 0x1)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec/exec.go:288 +0x63
os/exec.(*Cmd).Start.func1(0xc0003d4840, 0xc0004fcda0)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec/exec.go:409 +0x27
created by os/exec.(*Cmd).Start
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec/exec.go:408 +0x58f

goroutine 440 [IO wait]:
internal/poll.runtime_pollWait(0x1d19f38, 0x72, 0xffffffffffffffff)
	/usr/local/Cellar/go/1.12.1/libexec/src/runtime/netpoll.go:182 +0x56
internal/poll.(*pollDesc).wait(0xc0000972d8, 0x72, 0x8001, 0x8000, 0xffffffffffffffff)
	/usr/local/Cellar/go/1.12.1/libexec/src/internal/poll/fd_poll_runtime.go:87 +0x9b
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/Cellar/go/1.12.1/libexec/src/internal/poll/fd_poll_runtime.go:92
internal/poll.(*FD).Read(0xc0000972c0, 0xc00031c000, 0x8000, 0x8000, 0x0, 0x0, 0x0)
	/usr/local/Cellar/go/1.12.1/libexec/src/internal/poll/fd_unix.go:169 +0x1f2
os.(*File).read(...)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/file_unix.go:263
os.(*File).Read(0xc00020a1c0, 0xc00031c000, 0x8000, 0x8000, 0x0, 0xc0003d3700, 0x100716c)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/file.go:108 +0x70
io.copyBuffer(0x1581800, 0xc0004fcce0, 0x1581b60, 0xc00020a1c0, 0xc00031c000, 0x8000, 0x8000, 0x1006c45, 0xc000096e40, 0xc0003d37b0)
	/usr/local/Cellar/go/1.12.1/libexec/src/io/io.go:402 +0x122
io.Copy(...)
	/usr/local/Cellar/go/1.12.1/libexec/src/io/io.go:364
os/exec.(*Cmd).writerDescriptor.func1(0xc000096e40, 0xc0003d37b0)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec/exec.go:288 +0x63
os/exec.(*Cmd).Start.func1(0xc0003d4840, 0xc0004fcd60)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec/exec.go:409 +0x27
created by os/exec.(*Cmd).Start
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec/exec.go:408 +0x58f

goroutine 405 [semacquire]:
sync.runtime_Semacquire(0xc0002f4188)
	/usr/local/Cellar/go/1.12.1/libexec/src/runtime/sema.go:56 +0x39
sync.(*WaitGroup).Wait(0xc0002f4180)
	/usr/local/Cellar/go/1.12.1/libexec/src/sync/waitgroup.go:130 +0x65
github.com/uber/astro/astro/utils.Parallel(0xa, 0xc0000b20a0, 0x1, 0x1)
	/Users/dan/.go/src/github.com/uber/astro/astro/utils/parallel.go:37 +0x103
github.com/uber/astro/astro.(*Session).plan.func2(0xc00028a5a0, 0xc0000b20a0, 0x1, 0x1)
	/Users/dan/.go/src/github.com/uber/astro/astro/sessions.go:303 +0x6e
created by github.com/uber/astro/astro.(*Session).plan
	/Users/dan/.go/src/github.com/uber/astro/astro/sessions.go:301 +0x3cd

goroutine 435 [syscall]:
syscall.syscall6(0x1072cd0, 0x3205, 0xc0000dda9c, 0x0, 0xc00013a750, 0x0, 0x0, 0x0, 0x0, 0x0)
	/usr/local/Cellar/go/1.12.1/libexec/src/runtime/sys_darwin.go:74 +0x2e
syscall.wait4(0x3205, 0xc0000dda9c, 0x0, 0xc00013a750, 0x90, 0x14d1f40, 0xc00015f201)
	/usr/local/Cellar/go/1.12.1/libexec/src/syscall/zsyscall_darwin_amd64.go:42 +0x88
syscall.Wait4(0x3205, 0xc0000ddaec, 0x0, 0xc00013a750, 0xc0004fcc80, 0x1, 0x2)
	/usr/local/Cellar/go/1.12.1/libexec/src/syscall/syscall_bsd.go:129 +0x51
os.(*Process).wait(0xc00015f2c0, 0x1502b40, 0x1502b48, 0x1502b38)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec_unix.go:38 +0x7c
os.(*Process).Wait(...)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec.go:125
os/exec.(*Cmd).Wait(0xc0003d4840, 0x0, 0x0)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec/exec.go:474 +0x61
os/exec.(*Cmd).Run(0xc0003d4840, 0xdf6eb9bc2, 0x18aa1c0)
	/usr/local/Cellar/go/1.12.1/libexec/src/os/exec/exec.go:318 +0x5c
github.com/uber/astro/astro/exec2.(*Process).Run(0xc0000217a0, 0xc00020a1a0, 0x2)
	/Users/dan/.go/src/github.com/uber/astro/astro/exec2/process.go:111 +0x20d
github.com/uber/astro/astro/terraform.(*Session).detachModern(0xc000096840, 0x14e4388, 0x4, 0x0, 0x1)
	/Users/dan/.go/src/github.com/uber/astro/astro/terraform/terraform_remote_state_disable.go:99 +0x126
github.com/uber/astro/astro/terraform.(*Session).Detach(0xc000096840, 0xc0000ddeb8, 0xc0000ddec8, 0x1, 0x1)
	/Users/dan/.go/src/github.com/uber/astro/astro/terraform/terraform_remote_state_disable.go:53 +0x295
github.com/uber/astro/astro.(*Session).plan.func1()
	/Users/dan/.go/src/github.com/uber/astro/astro/sessions.go:280 +0x6de
github.com/uber/astro/astro/utils.Parallel.func1(0xc0002f4180, 0xc0004320c0, 0xc0000b0b00)
	/Users/dan/.go/src/github.com/uber/astro/astro/utils/parallel.go:32 +0x4d
created by github.com/uber/astro/astro/utils.Parallel
	/Users/dan/.go/src/github.com/uber/astro/astro/utils/parallel.go:30 +0xd9

goroutine 406 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0002c8370, 0xc00028a540)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54

goroutine 365 [chan receive]:
github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus.func1(0xc0000d2dc0, 0xc000097bc0)
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:45 +0xdc
created by github.com/uber/astro/astro/cli/astro/cmd.(*AstroCLI).printExecStatus
	/Users/dan/.go/src/github.com/uber/astro/astro/cli/astro/cmd/display.go:36 +0xb54
FAIL	github.com/uber/astro/astro/tests	60.027s
ok  	github.com/uber/astro/astro/tvm	31.869s	coverage: 68.8% of statements
ok  	github.com/uber/astro/astro/utils	0.020s	coverage: 7.7% of statements
make: *** [test] Error 1

Definitely a goroutine leak in there too, but only once per CLI execution so it's mainly a problem in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant