You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I created a script for our team that runs snapshot tests in record mode for iPhone/iPad with correctly selected devices and IOS version.
But when FBSnapshotTestCase runs in record mode we hit the assert:
assert(recordMode == false, message: "Test ran in record mode. Reference image is now saved. Disable record mode to perform an actual snapshot comparison!", file: file, line: line)
Which leads the whole Xcodebuild exiting with error code 65 with lots of red error lines.
When run using Xcode it is not a problem and is actually convenient (you can see which test were recorder). But when run for recording in one go - the output is too noisy.
Feature Request
Can we add a property shouldFailInRecordMode to the FBSnapshotTestCase so in SwiftSupport.swift the assert will change to:
assert(!(recordMode && shouldFailInRecordMode), message: "Test ran in record mode. Reference image is now saved. Disable record mode to perform an actual snapshot comparison!", file: file, line: line)
The text was updated successfully, but these errors were encountered:
Background
I created a script for our team that runs snapshot tests in record mode for iPhone/iPad with correctly selected devices and IOS version.
But when FBSnapshotTestCase runs in record mode we hit the assert:
Which leads the whole Xcodebuild exiting with error code 65 with lots of red error lines.
When run using Xcode it is not a problem and is actually convenient (you can see which test were recorder). But when run for recording in one go - the output is too noisy.
Feature Request
Can we add a property
shouldFailInRecordMode
to theFBSnapshotTestCase
so inSwiftSupport.swift
the assert will change to:The text was updated successfully, but these errors were encountered: