Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implementation of __getattr__ for UniSchema #655

Open
v01dXYZ opened this issue Mar 17, 2021 · 1 comment
Open

Remove implementation of __getattr__ for UniSchema #655

v01dXYZ opened this issue Mar 17, 2021 · 1 comment

Comments

@v01dXYZ
Copy link

v01dXYZ commented Mar 17, 2021

Hello,
I found a very minor issue (probably a typo):

def __getattr__(self, item) -> Any:
return super().__getattribute__(item)

This is not really required (basically since we don't reimplement __getattribute__, that will always be object.__getattribute__(obj, item) that will be invoked when we getattr).

@selitvin
Copy link
Collaborator

Thanks for the report. Will clean it up (or feel free to submit a fix in a PR :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants