Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight not working properly #1313

Open
lippyDesign opened this issue Apr 25, 2020 · 2 comments
Open

Highlight not working properly #1313

lippyDesign opened this issue Apr 25, 2020 · 2 comments
Labels

Comments

@lippyDesign
Copy link

lippyDesign commented Apr 25, 2020

If I do the follwing:

<XYPlot width={width} height={height}>
<HorizontalGridLines />
<VerticalGridLines />
<XAxis />
<YAxis />
<Highlight onBrushEnd={this.handleZoom} />
<HexbinSeries
    animation
    sizeHexagonsWithCount
    className="hexbin-size-example"
    radius={15}
    data={data}
    onValueClick={(datapoint, event) => {
        console.log({ datapoint, event });
    }}
/>

the highlighting drops randomly and unexpectedly (as if i release mouse), but i am still highlighting, however if I move Highlight to the end:

<XYPlot width={width} height={height}>
<HorizontalGridLines />
<VerticalGridLines />
<XAxis />
<YAxis />
<HexbinSeries
    animation
    sizeHexagonsWithCount
    className="hexbin-size-example"
    radius={15}
    data={data}
    onValueClick={(datapoint, event) => {
        console.log({ datapoint, event });
    }}
/>
<Highlight onBrushEnd={this.handleZoom} />

the highlighting works as expected, but now the Hexbin onValueClick event does not work. This is very annoying and is preventing us from going to prod with this

@Xiot
Copy link
Contributor

Xiot commented Jun 11, 2020

I'm working on cleaning up the Highlight component here #1354

My plan is to split it up so that the Zoom and Window parts of it are separate.
But the main advancement is moving the mouse handling to the XYPlot, which avoids the issues that you are seeing.

@prateek-redefcorp
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants