Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable To Resolve Module In 1.11.11 #1470

Closed
spencercharestpaypal opened this issue Jan 9, 2023 · 9 comments
Closed

Unable To Resolve Module In 1.11.11 #1470

spencercharestpaypal opened this issue Jan 9, 2023 · 9 comments

Comments

@spencercharestpaypal
Copy link

It appears react-vis can no longer be resolved due to changes made in #1469. It looks to me like either the build file dist/dist.min.js should be renamed to dist/index.js or that package.json main field should be updated to dist/dist.min.js. main is currently pointing to dist/index.js which no longer exist after the changes made in the referenced PR.

@kenns29
Copy link
Contributor

kenns29 commented Jan 10, 2023

I think we should rename main to dist/dist.min.js ... sorry, for some reason this error got bypassed my test in external repo

@kenns29
Copy link
Contributor

kenns29 commented Jan 10, 2023

considering this is a faulty publish, lemme revert the latest version (1.11.12) to the content of 1.11.7. Once we made the fix to the build system, I will bump the version to 1.12.0

@spencercharestpaypal
Copy link
Author

Thanks so much @kenns29 for the quick response! I'll update to 1.11.12.

@watson
Copy link

watson commented Jan 10, 2023

@kenns29 Hi, the new 1.11.12 version seems to be based off an older version of the code and doesn't for instance include the updates to the d3-* packages. Could it be that you accidentally published to npm from your local out-of-date fork of react-vis?

@kenns29
Copy link
Contributor

kenns29 commented Jan 10, 2023

@kenns29 Hi, the new 1.11.12 version seems to be based off an older version of the code and doesn't for instance include the updates to the d3-* packages. Could it be that you accidentally published to npm from your local out-of-date fork of react-vis?

@watson 1.11.11 has a bug that the main file in package.json doesn't match the correct file in dist, and it breaks the library for browser users. I have to revert the publish (by publishing the content of 1.11.7 to 1.11.12) to prevent breaking the library for people who do auto-update. Need to spend more time to fix the build system and prepare for a minor release instead of patch (the next one should be 1.12.0).

@rkok
Copy link

rkok commented Jan 27, 2023

Waiting eagerly for the fix, so that we can install the fixes from #1455 to stop npm audit --production from complaining.

@kenns29 Thank you for your work keeping the repository alive.

@ak2hr
Copy link

ak2hr commented Feb 15, 2023

@kenns29 are the 1.12.0 changes still actively being worked on/planned for release? Nothing immediately pressing, but the d3 vulnerabilities are still a thorn in the side of my team's application.

Thanks again for your efforts!

@kenns29
Copy link
Contributor

kenns29 commented Feb 16, 2023

It’s still planned, but I’m currently on parental leave, and I will get back to this in around May. I may be able to work on this causally when I can find some spare time. We mainly need to fix the browser bundle with the updates. I expect this to finish by June.

@ak2hr
Copy link

ak2hr commented Feb 16, 2023

Sounds good, thanks for the quick reply. And congrats on the kid!

@kenns29 kenns29 closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants