Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all (3) protocols of TChannel in HandleOrForward #23

Open
thanodnl opened this issue Oct 20, 2015 · 0 comments
Open

Support all (3) protocols of TChannel in HandleOrForward #23

thanodnl opened this issue Oct 20, 2015 · 0 comments

Comments

@thanodnl
Copy link
Contributor

Currently thrift over TChannel is not working as reported by #22. Before JSON over TChannel was not working as fixed by #14.

As one could see is that both PR's are the exact inverse of each other.

Since HandleOrForward is one of -maybe the biggest- driver to use Ringpop it should work on all supported TChannel protocols. We need to figure out how to do this the correct way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thanodnl