generated from ubiquity/ts-template
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New text config param for empty wallet #22
Comments
@whck6 you should first |
/wallet 0x1133830C73B2251DB9373e1B668D01E9dd2B99B1 |
+ Successfully registered wallet address |
/start |
Tips:
|
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 25 |
Review | Comment | 6 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Resolves #22 | 0content: p: symbols: \b\w+\b: count: 2 multiplier: 0 score: 1 multiplier: 0 | 0.1 | - |
I've added a new config it is called emptyWalletText. | 0content: p: symbols: \b\w+\b: count: 10 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
@Keyrxng Do you mind checking? | 0content: p: symbols: \b\w+\b: count: 5 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Updated. @rndquu I am misunderstanding and removed [it](https:… | 0content: p: symbols: \b\w+\b: count: 8 multiplier: 0.2 score: 1 a: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Updated. @rndquu | 0content: p: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Updated. | 0content: p: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
[ 0.21 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.21 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@whck6 you should first `/start` to assign yourself to t… | 2.1content: p: symbols: \b\w+\b: count: 20 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 1 | 0.1 | 0.21 |
[ 27.2 WXDAI ]
@rndquu
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 22.2 |
Review | Comment | 5 | 5 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Depends on https://github.com/ubiquity/safe.ubq.fi/issues/3 We'… | 22.2content: p: symbols: \b\w+\b: count: 34 multiplier: 0.1 score: 1 ol: symbols: \b\w+\b: count: 37 multiplier: 0.1 score: 0 li: symbols: \b\w+\b: count: 30 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 5 a: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 5 pre: symbols: \b\w+\b: count: 13 multiplier: 0.1 score: 0 multiplier: 3 | 1 | 22.2 |
The newly added `emptyWalletText` param should be used [… | 0.325content: p: symbols: \b\w+\b: count: 11 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 a: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 0.25 | 1 | 0.325 |
That's kind of overengineering, I'd keep a single param and intr… | 0.55content: p: symbols: \b\w+\b: count: 22 multiplier: 0.1 score: 1 multiplier: 0.25 | 1 | 0.55 |
https://github.com/ubiquibot/plugin-template/issues/19 | 0.2content: p: symbols: \b\w+\b: count: 8 multiplier: 0.1 score: 1 multiplier: 0.25 | 1 | 0.2 |
Let's just make the text configurable and decide later on the ex… | 3.3content: p: symbols: \b\w+\b: count: 48 multiplier: 0.1 score: 1 ol: symbols: \b\w+\b: count: 72 multiplier: 0.1 score: 0 li: symbols: \b\w+\b: count: 66 multiplier: 0.1 score: 1 a: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 17 multiplier: 0.1 score: 1 multiplier: 0.25 | 1 | 3.3 |
Works fine. @whck6 Could you also update readme docs https://git… | 0.625content: p: symbols: \b\w+\b: count: 25 multiplier: 0.1 score: 1 multiplier: 0.25 | 1 | 0.625 |
[ 28.7 WXDAI ]
@Keyrxng
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Review | Comment | 3 | 28.7 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@rndquu There was a slight variance here because this comment is… | 6.4content: p: symbols: \b\w+\b: count: 61 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 3 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 6.4 |
@whck6 Thanks for the PR. Just so you know, this PR can't be me… | 18.8content: h2: symbols: \b\w+\b: count: 89 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 p: symbols: \b\w+\b: count: 98 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 18.8 |
@rndquu my mistake I misunderstood things originally, confused m… | 3.5content: p: symbols: \b\w+\b: count: 35 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 3.5 |
@Keyrxng, May I know when I will receive 25 WXDAI? I feel It would be immediate but no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Depends on ubiquity/safe.ubq.fi#3
We're going to have 2 registration flows:
/wallet
commandsafe.ubq.fi
(example)The
command-start-stop
plugin displays a warning message whenstartRequiresWallet = true
and user doesn't have a registered wallet:Since we're going to have 2 flows the message above is not applicable for the "webauthn" flow. Possible solution could be to add a new plugin option for the warning message like
emptyWalletText
.The text was updated successfully, but these errors were encountered: