Review incentives bug

[whilefoo]

An issue occurred in #275 where @gentlementlegen got this review reward:

Changes	Priority	Reward
+10026 -10166	4	807.68

The PR #282 shows only +48 −194 lines changed. I ran it locally and found that the diff was done with bf23ebc as a base commit and 86a9a70 as a head commit.

As you can see the base commit that should've been used is 41bae52
However after manually browsing the API it appears this is not a mistake in the code but actually the API for the first commit in the PR returns bf23ebc as a parent.

{
    "sha": "fe2a3142683d1bff174f7d23d9850482cec9ac2c",
    "node_id": "C_kwDONSZY49oAKGZlMmEzMTQyNjgzZDFiZmYxNzRmN2QyM2Q5ODUwNDgyY2VjOWFjMmM",
    "commit": {
      "author": {
        "name": "whilefoo",
        "email": "whilefoo@users.noreply.github.com",
        "date": "2025-02-17T18:59:09Z"
      },
      "committer": {
        "name": "whilefoo",
        "email": "whilefoo@users.noreply.github.com",
        "date": "2025-02-17T18:59:09Z"
      },
      "message": "fix: parent commit",
      "tree": {
        "sha": "34fb58b4ab4e80053d808bcbbb06c7bfc04872c2",
        "url": "https://api.github.com/repos/ubiquity-os-marketplace/text-conversation-rewards/git/trees/34fb58b4ab4e80053d808bcbbb06c7bfc04872c2"
      },
      "url": "https://api.github.com/repos/ubiquity-os-marketplace/text-conversation-rewards/git/commits/fe2a3142683d1bff174f7d23d9850482cec9ac2c",
      "comment_count": 0,
      "verification": {
        "verified": false,
        "reason": "unsigned",
        "signature": null,
        "payload": null,
        "verified_at": null
      }
    },
    "url": "https://api.github.com/repos/ubiquity-os-marketplace/text-conversation-rewards/commits/fe2a3142683d1bff174f7d23d9850482cec9ac2c",
    "html_url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/fe2a3142683d1bff174f7d23d9850482cec9ac2c",
    "comments_url": "https://api.github.com/repos/ubiquity-os-marketplace/text-conversation-rewards/commits/fe2a3142683d1bff174f7d23d9850482cec9ac2c/comments",
    "author": {
      "login": "whilefoo",
      "id": 139262667,
      "node_id": "U_kgDOCEz6yw",
      "avatar_url": "https://avatars.githubusercontent.com/u/139262667?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/whilefoo",
      "html_url": "https://github.com/whilefoo",
      "followers_url": "https://api.github.com/users/whilefoo/followers",
      "following_url": "https://api.github.com/users/whilefoo/following{/other_user}",
      "gists_url": "https://api.github.com/users/whilefoo/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/whilefoo/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/whilefoo/subscriptions",
      "organizations_url": "https://api.github.com/users/whilefoo/orgs",
      "repos_url": "https://api.github.com/users/whilefoo/repos",
      "events_url": "https://api.github.com/users/whilefoo/events{/privacy}",
      "received_events_url": "https://api.github.com/users/whilefoo/received_events",
      "type": "User",
      "user_view_type": "public",
      "site_admin": false
    },
    "committer": {
      "login": "whilefoo",
      "id": 139262667,
      "node_id": "U_kgDOCEz6yw",
      "avatar_url": "https://avatars.githubusercontent.com/u/139262667?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/whilefoo",
      "html_url": "https://github.com/whilefoo",
      "followers_url": "https://api.github.com/users/whilefoo/followers",
      "following_url": "https://api.github.com/users/whilefoo/following{/other_user}",
      "gists_url": "https://api.github.com/users/whilefoo/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/whilefoo/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/whilefoo/subscriptions",
      "organizations_url": "https://api.github.com/users/whilefoo/orgs",
      "repos_url": "https://api.github.com/users/whilefoo/repos",
      "events_url": "https://api.github.com/users/whilefoo/events{/privacy}",
      "received_events_url": "https://api.github.com/users/whilefoo/received_events",
      "type": "User",
      "user_view_type": "public",
      "site_admin": false
    },
    "parents": [
      {
        "sha": "bf23ebc61b00671818a88121b05897a4529ad15e",
        "url": "https://api.github.com/repos/ubiquity-os-marketplace/text-conversation-rewards/commits/bf23ebc61b00671818a88121b05897a4529ad15e",
        "html_url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/bf23ebc61b00671818a88121b05897a4529ad15e"
      }
    ]
  }

I haven't confirmed this but the most likely explanation is that bf23ebc was the parent when I created the branch locally but later merged latest changes from development into the branch.

[ubiquity-os-beta]

Note

The following contributors may be suitable for this task:

whilefoo

80% Match ubiquity-os-marketplace/text-conversation-rewards#275

gentlementlegen

79% Match ubiquity-os-marketplace/text-conversation-rewards#262
78% Match ubiquity-os-marketplace/text-conversation-rewards#164

ishowvel

78% Match ubiquity-os/plugins-wishlist#60

[0x4007]

I'm pretty sure there was a task to 1. Write the report that you did and 2. Fix the problem.

Looks like you delivered half the work with this spec already.