Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CallbackBuilder #33

Open
Keyrxng opened this issue Nov 6, 2024 · 1 comment
Open

CallbackBuilder #33

Keyrxng opened this issue Nov 6, 2024 · 1 comment

Comments

@Keyrxng
Copy link
Member

Keyrxng commented Nov 6, 2024

          Don't hesitate to move that to the SDK, it makes things much simpler!

This PR introduces a CallbackBuilder to replace the single handler input that SDK create methods use now. This is so a dev can create handlers for multiple webhook events and the SDK process them all as a single fn for any given event.

Proxy logic has been simplified via the new CallbackBuilder and the SDK should export it. (This task may need transferred into the SDK if it's no longer exported from this repo)

Originally posted by @gentlementlegen in ubiquity-os-marketplace/command-ask#9 (review)

@Keyrxng
Copy link
Member Author

Keyrxng commented Nov 23, 2024

This should be transferred into https://github.com/ubiquity-os/plugin-sdk

Also if this is labelled I'm happy to re-sub the PR

@gentlementlegen gentlementlegen transferred this issue from ubiquity-os/ubiquity-os-kernel Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant