Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync code between ubiquity/devpool-directory and ubiquity/devpool-directory-private #25

Open
rndquu opened this issue May 16, 2024 · 7 comments

Comments

@rndquu
Copy link
Member

rndquu commented May 16, 2024

There are 2 repositories which collect issues available for contributors:

  1. https://github.com/ubiquity/devpool-directory: Public repo, any contributor can take issue there
  2. https://github.com/ubiquity/devpool-directory-private: Private repo, only core contributors can take issues there since that repo issues may contain sensitive/NDA data

The issue is that we somehow need to sync code changes between https://github.com/ubiquity/devpool-directory and https://github.com/ubiquity/devpool-directory-private. We can't simply fork https://github.com/ubiquity/devpool-directory-private from https://github.com/ubiquity/devpool-directory and use github UI since private repos can't be synced.

What should be done:

Possible solution described here

@jordan-ae
Copy link

@rndquu This up for grabs?

@rndquu
Copy link
Member Author

rndquu commented May 27, 2024

@rndquu This up for grabs?

Yes, you may setup code sync between https://github.com/ubiquity/devpool-directory and your forked instance of https://github.com/rndquu/devpool-directory-private-test for testing purposes and open a PR, I will check how it works with https://github.com/ubiquity/devpool-directory-private then

@jordan-ae
Copy link

/start

Copy link

ubiquibot bot commented May 28, 2024

DeadlineWed, May 29, 10:06 PM UTC
Registered Wallet 0x2F05fD58023B0a95d1866aa0A3b672cEf05945c5
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented Jun 4, 2024

# These linked pull requests are closed:  <a href="https://github.com/ubiquity/devpool-directory/pull/1193">#1193</a> 

@0x4007
Copy link
Member

0x4007 commented Oct 17, 2024

I think we should use a git submodule. Basically we set up the private Directory to import all the contents of the public Directory, and then we overwrite the behavior of what needs to be different.

@rndquu
Copy link
Member Author

rndquu commented Oct 17, 2024

I think we should use a git submodule. Basically we set up the private Directory to import all the contents of the public Directory, and then we overwrite the behavior of what needs to be different.

Ideally all of the changes should be made in https://github.com/ubiquity/devpool-directory, in particular:

  1. Add a new env variable, like MODE=public|private
  2. If MODE=private then disable tweeting
  3. Move opt.json and projects.json to env variables
  4. Probably smth else

So that we could simply:

  1. Fork https://github.com/ubiquity/devpool-directory to https://github.com/ubiquity/devpool-directory-bounties
  2. Setup all env variables so that https://github.com/ubiquity/devpool-directory-bounties worked "out of the box" without any code changes
  3. Setup code sync as described here so that we could sync code via github UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants