-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup slither
#3
Comments
! action has an uncaught error |
! action has an uncaught error |
Hey should I use the --triage-mode? or simply can I comment |
This issue implies refactoring the code in a way that fixes warnings, we shouldn't disable detectors with |
But the thing is all warnings come from the openzeppelin libraries, is it correct refactoring audited code only to get all green? is not possible that they are false positives? |
Could you show slither's output? |
The
|
yep, but should we look at |
Well, I've been reviewing the code and I only found the cases of:
require(initialOwner != address(0), "Initial owner cannot be zero address");
Then the other warnings come from OpenZeppelin libraries, but I don't find it necessary modifying them. |
Yes
This issue implied fixing low severity warnings (where it makes sense). Mixed case and |
/start |
Tips:
|
! action has an uncaught error |
The bot did not respond! This happened because I opened two PR at the same time right? |
Hard to say, @pavlovcik might know better |
+ Evaluating results. Please wait... |
I've never seen this scenario before. But yesterday there was some strange behavior I think on GitHub's side with the pull request links. One of our contributors was unable to automatically link their pull request to the issue via
There's another issue I've never seen so I'll handle the payout manually. https://gnosisscan.io/tx/0xb245990569cebe0757c42d8d2ac29d284fc44484df0feea6e521b2b8533fedd5 |
What should be done:
info
warnings produced byslither .
development
branch (make sure it fails if there are any warnings, example)The text was updated successfully, but these errors were encountered: