Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security monitoring #927

Open
Tracked by #928
rndquu opened this issue Apr 16, 2024 · 53 comments · May be fixed by #959
Open
Tracked by #928

Security monitoring #927

rndquu opened this issue Apr 16, 2024 · 53 comments · May be fixed by #959
Assignees
@alexandr-masl
Labels
Price: 600 USD Priority: 2 (Medium) Time: <1 Day

Comments

@rndquu
Copy link
Member

rndquu commented Apr 16, 2024 •
edited
Loading

In case of a security incident we should:

  1. Pause all of the contracts
  2. Notify the core team that something went wrong

Possible solutions for monitoring:

What should be done:

  1. Setup monitoring for LibUbiquityPool. In case of a possible security incident (let's say >30% of liquidity is withdrawn) we should:
    a) Pause the UbiquityDollarToken
    b) Pause LibUbiquityPool by disabling collateral
  2. Send notification to https://t.me/UbiquityDAO (you may create a new topic there like Dollar monitoring)

P.S. Mainnet contract addresses can be found here
@rndquu rndquu mentioned this issue Apr 16, 2024
Open
4 tasks
@molecula451
Copy link
Member

Hi rndqnuu there is another potential monitor solution available at mainnet, https://cyvers.ai/

@rndquu
Copy link
Member Author

rndquu commented Apr 17, 2024

Hi rndqnuu there is another potential monitor solution available at mainnet, https://cyvers.ai/

Updated description

@0xJoichiro
Copy link

/help

@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented May 8, 2024

Available Commands

Command Description Example
/start Assign yourself to the issue. /start
/stop Unassign yourself from the issue. /stop
/help List all available commands. /help
/query Returns the user's wallet, access, and multiplier information. /query @user
/ask Ask a context aware question. /ask is x or y the best approach?
/multiplier Set the task payout multiplier for a specific contributor, and provide a reason for why. /multiplier @user 0.5 "multiplier
reason"
/labels Set access control, for admins only. /labels @user priority time
price
/authorize Approve a label change, for admins only. /authorize
/wallet Register your wallet address for payments. /wallet ubq.eth

@0xJoichiro 0xJoichiro mentioned this issue May 8, 2024
Closed
@gitcoindev
Copy link
Contributor

gitcoindev commented May 8, 2024 •
edited
Loading

@0xJoichiro I received the notification, can you please add a comment with /start command instead of /help now to have the issue assigned to you?

@0xJoichiro
Copy link

/start

@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented May 8, 2024 

# Skipping to register a wallet address because both address/ens doesn't exist

@gitcoindev
Copy link
Contributor

/query @0xJoichiro

@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented May 8, 2024 

! action has an uncaught error

@gitcoindev
Copy link
Contributor

@0xJoichiro could you please try to register your wallet address for payouts using /wallet 0xYOURETHWALLETADDRESS command ?

@0xJoichiro
Copy link

@0xJoichiro could you please try to register your wallet address for payouts using /wallet 0xYOURETHWALLETADDRESS command ?

yes sir,I'll create a wallet and try this asap

@0xJoichiro
Copy link

/wallet 0x2C35d567b68Adf4FcE2b89e9c0aE70Ea119C209A

@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented May 9, 2024 

+ Successfully registered wallet address

@0xJoichiro
Copy link

/start

@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented May 9, 2024

DeadlineFri, May 10, 11:58 AM UTC
Registered Wallet 0x2C35d567b68Adf4FcE2b89e9c0aE70Ea119C209A
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@0xJoichiro 0xJoichiro mentioned this issue May 10, 2024
Closed
@0xJoichiro
Copy link

0xJoichiro commented May 10, 2024 •
edited by gitcoindev
Loading

@gitcoindev does this work as a draft PR #938?

Yes, please mark it as ready for review when it will be ready.

@molecula451
Copy link
Member

@0xJoichiro the message it's not clear do you think the PR is ready to review?

@0x4007
Copy link
Member

0x4007 commented Sep 8, 2024

/start

@gentlementlegen can you trim and parse commands so they execute even with the \n at the end?

@gentlementlegen
Copy link
Member

@0x4007 yes I opened a ticket on ubiquibot-kernel about it.

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Sep 8, 2024

@alexandr-masl the deadline is at Mon, Sep 9, 8:42 AM UTC

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Sep 11, 2024

@alexandr-masl, this task has been idle for a while. Please provide an update.

@rndquu
Copy link
Member Author

rndquu commented Sep 11, 2024 •
edited
Loading

@alexandr-masl The point regarding telegram notifications is not mandatory if some other notification method (email?) is available on the monitoring platform.

If https://www.openzeppelin.com/defender supports setting up telegram notification in few clicks then it's fine. Otherwise if it only supports email notifications then it's also fine. There's no need to overengineer, just select a notification solution which can be set up in a couple of clicks (and we'll add telegram notifcations later).

@alexandr-masl
Copy link
Contributor

openzeppelin.com/defender

Got it! I was deciding between Chainlink and OpenZeppelin, but I’m leaning towards implementing OpenZeppelin Defender since it offers built-in notifications like Slack, Telegram, and email right out of the box, plus it supports webhooks, allowing to send notifications to any external service or platform

@alexandr-masl alexandr-masl linked a pull request Sep 12, 2024 that will close this issue
Open
@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Sep 15, 2024

@alexandr-masl, this task has been idle for a while. Please provide an update.

4 similar comments
@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Sep 19, 2024

@alexandr-masl, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Sep 19, 2024

@alexandr-masl, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Sep 24, 2024

@alexandr-masl, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Sep 30, 2024

@alexandr-masl, this task has been idle for a while. Please provide an update.

@alexandr-masl
Copy link
Contributor

Hey @rndquu, can you please reassign me? Also, I'm still waiting for your review on this pull request. Let me know if there's anything I can help with, as I haven't seen any updates in a while

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Oct 21, 2024

@alexandr-masl the deadline is at Tue, Oct 22, 8:15 AM UTC

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Nov 10, 2024

Passed the deadline and no activity is detected, removing assignees: @alexandr-masl.

@alexandr-masl
Copy link
Contributor

Hey @rndquu, just checking in to see if there’s a chance my PR might be reviewed soon. It’s been waiting for over 2 months now, and I’d really appreciate even a rough estimate so I can adjust my plans accordingly. Thanks in advance

@alexandr-masl
Copy link
Contributor

/query

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Dec 13, 2024 

Failed to run command-query-user.
error: missing required argument 'username'

Usage: program [options] [command]

Options:
  -h, --help                   display help for command

Commands:
  /query [options] <username>
  help [command]               display help for command

@alexandr-masl
Copy link
Contributor

/query @alexandr-masl

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Dec 13, 2024

Property Value
Wallet 0x01Ae8d6d0F137CF946e354eA707B698E8CaE6485

@alexandr-masl
Copy link
Contributor

/wallet 0x37Dd2F550E177F753d4b383dA86010e5Ad58C16c

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Dec 13, 2024 

+ Successfully registered wallet address

@alexandr-masl
Copy link
Contributor

/query @alexandr-masl

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Dec 13, 2024

Property Value
Wallet 0x37Dd2F550E177F753d4b383dA86010e5Ad58C16c

@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Dec 13, 2024

@alexandr-masl the deadline is at Sat, Dec 14, 5:02 PM UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandr-masl alexandr-masl

Labels
Price: 600 USD Priority: 2 (Medium) Time: <1 Day
Projects
None yet
Milestone
No milestone
9 participants
@0x4007 @suminc7 @gentlementlegen @molecula451 @alexandr-masl @gitcoindev @rndquu @0xJoichiro @LurkyLunk