Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lower casing in PathMakeStandard #166

Open
kudaba opened this issue Feb 2, 2022 · 3 comments
Open

Remove lower casing in PathMakeStandard #166

kudaba opened this issue Feb 2, 2022 · 3 comments

Comments

@kudaba
Copy link
Contributor

kudaba commented Feb 2, 2022

I noticed that in my fork I have two commits for disabling this. The first was when I got it running in .net core I had to disable it for linux systems. And second time I added a user option to disable it completely since it was breaking tt files on windows. Is there a particular reason you want to force lower case on the filenames on windows where the case doesn't matter anyway?

I've been running with it completely disable for some time and haven't noticed any issues that I can recall.

@belkiss
Copy link
Contributor

belkiss commented Feb 2, 2022

Heya!
Not really, I've been trying to make sharpmake case correct for some time (with the introduction of the FileSystemComparer etc.), and slowly getting there :)

@kudaba
Copy link
Contributor Author

kudaba commented Feb 2, 2022

In that case I'll remove my change that adds a user option and just remove the casing code entirely and make a pr for it

@BrokenMarkus
Copy link

This was quite some time ago. How are things going on the case correct work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@belkiss @kudaba @BrokenMarkus and others