Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(art): add some wallpapers #1032

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

Xe
Copy link
Contributor

@Xe Xe commented Mar 17, 2024

I am donating these pictures to the Universal Blue project. Should you want to use these in Bazzite, feel free to. I hope these can give users some joy in the default config. These are some of my favorite pictures and sharing is caring.

Please let me know if you want more, I'm sure I can dig some up.

All of these except foothills.jpeg were shot on a Canon EOS R10.

Please let me know if I should lower the JPEG quality.

Photos are CC BY-SA 4.0.

@Xe Xe requested a review from castrojo as a code owner March 17, 2024 14:04
@Xe Xe changed the title usr/share/backgrounds: add some wallpapers feat(art): add some wallpapers Mar 17, 2024
@nicknamenamenick
Copy link
Contributor

I think the sea needle image would work well for a default Bazzite wallpaper.

nicknamenamenick added a commit to nicknamenamenick/bazzite-nickname that referenced this pull request Mar 21, 2024
@Xe
Copy link
Contributor Author

Xe commented Mar 21, 2024

Let me know what I need to do to PR it to bazzite and it shall be done. What format do you want? 100% JPEG is pretty neutral but also disk-chonky. The files I PR'd here are slightly postprocessed with Affinity Photo, but I can reprocess it to any format you want. IIRC JXL support just landed in GNOME, I don't know about KDE.

bketelsen
bketelsen previously approved these changes Mar 21, 2024
@m2Giles m2Giles enabled auto-merge March 21, 2024 18:16
@Xe
Copy link
Contributor Author

Xe commented Mar 22, 2024

Can someone retry CI?

@bketelsen bketelsen disabled auto-merge March 22, 2024 11:32
@bketelsen
Copy link
Member

the asus builds are still failing :(

@castrojo
Copy link
Member

castrojo commented Mar 22, 2024 via email

@fiftydinar
Copy link
Collaborator

fiftydinar commented Mar 22, 2024

Wallpapers are too big in size. 1MB & under is the recommendation.

Some slower hardware configurations would take some time to load the wallpaper.

Consider using JPEG-XL format for efficiently compressing the images without loosing quality.
XL-Converter is a good GUI program for this.

This is not a big deal, but just a nitpick, as wallpapers are loaded only once.
It would be a bit bigger deal if those wallpapers were of light/dark variant, as Gnome Shell always reloads the wallpaper when switching the theme, which can stutter on slower hardware configurations.

So merging this as is is also okay.

Thanks for contribution!

@Xe
Copy link
Contributor Author

Xe commented Mar 22, 2024

Is there a way to seamlessly load multiple variants of a single wallpaper in the same .xml file? I shipped my files as 100% JPEG because I wanted to preserve quality for downstream compression. I am more than happy to create more lossy JXL versions.

I am also working on a git repo that will produce RPM files that can be consumed by projects such as bluefin and bazzite.

@fiftydinar
Copy link
Collaborator

fiftydinar commented Mar 22, 2024

Is there a way to seamlessly load multiple variants of a single wallpaper in the same .xml file?

That is not currently possible.

I shipped my files as 100% JPEG because I wanted to preserve quality for downstream compression.

That's understandable. I don't know which software for editing images are you using, but if you can export edited RAW photo as lossless & acceptable-losy JPEG-XL, It would be interesting to know what file-size it would be for those. I bet it would look the same in quality while having smaller file-size. If software doesn't support exporting to JPEG-XL, maybe you can try to export images as PNGs & then converting those to JPEG-XL.

If you shoot those photos as JPEGs, then there's nothing that can be done to 100% preserve the quality. But maybe JPEG-XL can make the quality acceptable.

I am also working on a git repo that will produce RPM files that can be consumed by projects such as bluefin and bazzite.

Nice

@Xe
Copy link
Contributor Author

Xe commented Mar 22, 2024

Is 85 quality JXL okay?

$ du -hs jxl* orig
41M     jxl-lossless
3.1M    jxl-85
51M     orig

https://xena.greedo.xeserv.us/files/xe_clouds.jxl (JXL 85%)

@fiftydinar
Copy link
Collaborator

Is 85 quality JXL okay?

Looks great! Can't notice any difference even when peeping on my 4K 27 inch screen

@castrojo
Copy link
Member

castrojo commented Mar 22, 2024 via email

@Xe
Copy link
Contributor Author

Xe commented Mar 22, 2024

Would packages like this work? https://xena.greedo.xeserv.us/pkg/wallpapers/

@fiftydinar
Copy link
Collaborator

Would packages like this work? xena.greedo.xeserv.us/pkg/wallpapers

This looks good imo, I would ship it like this

Signed-off-by: Xe Iaso <me@xeiaso.net>
@castrojo castrojo merged commit 59aa407 into ublue-os:main Mar 25, 2024
19 of 30 checks passed
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Signed-off-by: Xe Iaso <me@xeiaso.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants