Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: just dx-group append group entry from /usr/lib/group #1767

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

obispobruno
Copy link
Contributor

just dx-group would not add group to user. with this pr it checks if the group exists in /etc/group, and if not it appends from /usr/lib/group

@obispobruno obispobruno requested a review from castrojo as a code owner October 10, 2024 16:12
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. dx Developer Experience Image specific labels Oct 10, 2024
Copy link
Member

@m2Giles m2Giles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 12, 2024
@m2Giles m2Giles added this pull request to the merge queue Oct 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 12, 2024
@bsherman bsherman added this pull request to the merge queue Oct 12, 2024
@bsherman
Copy link
Contributor

I am confused how it failed merge queue status checks in only a few minutes and left no history of its failure. So I re-added to merge queue to watch.

@bsherman
Copy link
Contributor

It did leave history, i just don't always read well.

@bsherman bsherman removed this pull request from the merge queue due to a manual request Oct 12, 2024
@bsherman
Copy link
Contributor

Ok, i see the problem
/tmp/nvidia-install.sh: line 54: NVIDIA_FLAVOR: unbound variable

https://github.com/ublue-os/bluefin/actions/runs/11306755007/job/31447703956#step:21:897

@p5 p5 mentioned this pull request Oct 12, 2024
@bsherman bsherman added this pull request to the merge queue Oct 12, 2024
Merged via the queue into ublue-os:main with commit 4729268 Oct 12, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience Image specific lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants