-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(just): add brew-command-not-found setup #1874
Conversation
0a41c5e
to
b1e2086
Compare
b1e2086
to
4a364fa
Compare
I think this might be a bit too much. Especially if this is going to install something from brew automatically. While brew is present, it is very much in an opt-in configuration. |
This probably should just be a justfile, right? Ill convert it over to that! |
7e2cf61
to
7b8c124
Compare
There you go! It seems to work fine on my machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is often quite easy to misunderstand the intention of the review comments let me make it clear here: There are absolutely no rhetorical questions in my comments and all questions are well intended and out of curiosity of understanding your intentions and learning a few things ;)
Most of the answers to your questions are: I just wrote bad code! Ill probably rewrite the just recipe with your review :p Thanks for reviewing! |
Im on my phone right now so I cant fix the recipe rn, but ill get on my computer, rewrite it and add some comments to clear up the logic |
7b8c124
to
a46a709
Compare
Just added two comments on the review. Please check them. I can't seem to unresolve the issues or I am too blind to find the button... ;) |
a46a709
to
7278a12
Compare
@tulilirockz resolve the merge conflict. |
7278a12
to
cfa78d8
Compare
cfa78d8
to
982b291
Compare
982b291
to
a25ab19
Compare
Should be good now - Fixed a few things that @lem4s mentioned, too |
This should setup command-not-found alongside brew-setup. The only thing missing is fish support that I couldnt set up yet (idk why it isnt working). Otherwise this seems good? Just needs a bit more testing. - Fixes #1327