Shell history sometimes doesn't save into Atuin

[x0ba]

Describe the bug

Sometimes when I issue commands in Bash, they don't get saved into the Atuin history menu. No changes have been made to the .bashrc but the initial ujust bluefin-cli command.

What did you expect to happen?

Every command is saved into the Atuin history menu.

Output of bootc status

No staged image present
Current booted image: ghcr.io/ublue-os/bluefin-dx:stable-daily
    Image version: 41.20241206 (2024-12-06 01:12:52 UTC)
    Image digest: sha256:94330c20b298846e910da50362e592a55502d80565c649b333e8c1d9a45780d8
Current rollback state is native ostree

Output of groups

daniel wheel docker incus-admin libvirt

Extra information or context

No response

[hanthor]

I'm wondering if the starship prompt is clobbering the bash history. Kind like when you put a space before the command it doesn't save to history

[castrojo]

This is horribly annoying but I don't have time to investigate. This doesn't happen ootb just the people that opt into bluefin-cli, but it would be nice to figure out what's going on here.

[hanthor]

I'll try to get to bottom of it.

I'll compare what get put in the bashrc from.

https://github.com/ublue-os/bluefin/blob/main/system_files%2Fshared%2Fusr%2Fshare%2Fublue-os%2Fbluefin-cli%2Fbling.sh#L24

[x0ba]

This seems to be a problem solely with the bash implementation for atuin, as this issue doesn't happen when I'm using zsh

[phroi]

Hello Bluefin folks, thank you all for your hard work!! 🤗

As I was saying on Discord, I have the very same issue with bluefin-cli's atuin: atuin history is finnicky as it doesn't record all the commands in its own history. The same was happening before when I was trying out BlueFin in brand new VM installations. No sync account set up. Sometimes it worked, but most of the times it was finicky. To me seems that if history is recalled even one time with Ctrl+R, then it starts working properly (🤔?)

I looked a bit online and it may be some interference between atuin and pre-exec: atuinsh/atuin#380

I also noticed that some changes are gonna happen to how pre-exec enter the system: #2039 (comment)

So you may want to take a look at this while touching that part 🎯

Love & Peace, Phroi

[tulilirockz]

I've noticed this comment on the mentioned issue on the Atuin sources, I made a PR that forces bling.sh to be only sourced a single time, this should fix these problems, but I am not super sure if it works yet. Anyone mind testing this out? #2072

[castrojo]

This seems to have fixed it for me! To test, rpm-ostree usroverlay to turn on write, copy the file over from the PR, then close terminal and test.

(Rebooting will put you back into "production mode".)

[x0ba]

Yeah, this seems to have fixed the problem for me as well. I see the PR's already been merged, so I'll go ahead and close this issue.