fix(ci): never skip successful builds check #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castrojo
approved these changes
Nov 30, 2023
p5
approved these changes
Nov 30, 2023
| runs-on: ubuntu-latest | ||
| needs: [push-ghcr] | ||
| steps: | ||
| - name: Exit on failure | ||
| if: ${{ needs.push-ghcr.result == 'failure' }} |
There was a problem hiding this comment.
This is very nice! Might have to steal reference this for my own workflows...
This was referenced Nov 30, 2023
b-
pushed a commit
to briorg/bluefin
that referenced
this pull request
Dec 9, 2023
awesomekyle
pushed a commit
to awesomekyle/bluefin
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations the general
Check all builds successfulwill be skipped. There for it is possible that the required check in the PR will be ignored, even if a build is not build successful.This implementation will ensure that the check is always run, unless it is canceled. When it runs it checks the result for failure.
It should only turn green if all builds are green.