Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Switch to system level flatpaks #790

Merged
merged 2 commits into from
Jan 29, 2024
Merged

feat: Switch to system level flatpaks #790

merged 2 commits into from
Jan 29, 2024

Conversation

KyleGospo
Copy link
Member

No description provided.

This was referenced Jan 4, 2024
Closed
Closed
EyeCantCU
EyeCantCU previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Consistency between Bluefin and Bazzite will be nice

@KyleGospo KyleGospo marked this pull request as ready for review January 5, 2024 00:03
@KyleGospo KyleGospo requested a review from castrojo as a code owner January 5, 2024 00:03
p5
p5 previously approved these changes Jan 5, 2024
View reviewed changes
@castrojo
Copy link
Member

castrojo commented Jan 5, 2024

Should we wait to see what the flatpak installation method will be in the installer?

@ispanos
Copy link
Contributor

ispanos commented Jan 5, 2024 •
edited
Loading

@KyleGospo Can you please add a new line at the end of the list? It would be easier to append more packages with echo when building on top of bluefin with startingpoint. I think its already there, sorry.

@KyleGospo KyleGospo dismissed stale reviews from p5 and EyeCantCU via 2be8ed4 January 6, 2024 10:08
@ispanos
Copy link
Contributor

ispanos commented Jan 7, 2024

Should we wait to see what the flatpak installation method will be in the installer?

Can we merge the fix and decided about the installation later?

@nicknamenamenick nicknamenamenick mentioned this pull request Jan 8, 2024
Merged
@KyleGospo KyleGospo enabled auto-merge January 26, 2024 23:40
@KyleGospo
Copy link
Member Author

@castrojo Rebased and ready for review

@KyleGospo KyleGospo added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit 9eaed15 Jan 29, 2024
30 checks passed
@KyleGospo KyleGospo deleted the system-flatpaks branch January 29, 2024 23:11
@github-actions github-actions bot mentioned this pull request Jan 29, 2024
Merged
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
Merged
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
@KyleGospo
feat: Switch to system level flatpaks (ublue-os#790)
2a509af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ispanos ispanos ispanos left review comments

@castrojo castrojo castrojo approved these changes

@p5 p5 p5 left review comments

@EyeCantCU EyeCantCU EyeCantCU left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleGospo @castrojo @ispanos @EyeCantCU @p5