fix: improve ujust bluefin-cli #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the use of all of toolboxes in ublue-os/toolboxes Dynamically fetches the Quadlets and makes systemd targets Moves the inline ujust command to it's own script
|
I will have to head to bed (it is midnight here), but i will continue looking at this tomorrow unless someone else picks up where i left off. |
|
Would also recommend adding an exit in case the user cancels a selection (for example when selecting a container they can press ESC to cancel, this will return an empty string, this currently seems to lock the script |
|
That seems smart. Each question should resolve to a variable. If a variable is empty bail out. Right now a SIGINT or empty string will put the script in a bad state. I also should move all questions to occur before any execution. For the loops that might be an issue but |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the use of all of toolboxes in ublue-os/toolboxes
Dynamically fetches the Quadlets and makes systemd targets
Moves the inline ujust command to it's own script