Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Fortress 2 fix for non-working game sounds #209

Closed
fiftydinar opened this issue May 16, 2023 · 2 comments
Closed

Team Fortress 2 fix for non-working game sounds #209

fiftydinar opened this issue May 16, 2023 · 2 comments

Comments

@fiftydinar
Copy link
Contributor

Describe the package

When playing TF2 on Fedora, you will notice that various sounds don't emit, like music, character voices etc.

The issue is that the sound engine of TF2 is using execheap for MP3 sound decoding, which is something that SELinux permits.

More details on this:
ValveSoftware/Source-1-Games#2734 (comment)

The not so good & secure solution is just disabling SELinux completely.

Proper solution:
Incorporate simple SELinux rule in rpm by Kylegospo which is only targeting the TF2 executable.

Package:
https://copr.fedorainfracloud.org/coprs/kylegospo/hl2linux-selinux/

Information on the package

Can't display it with dnf info

Image

All Images

@castrojo
Copy link
Member

image

Capturing from Discord.

@akdev1l
Copy link
Contributor

akdev1l commented May 17, 2023

I couldn't find any references to such RCE specifically in the audio libraries of that game.

in any case the policy from that issue it's not just targetting the tf2 binary - it seems equivalent to toggling execheap as it is allowing anything running on spc_t context.

Just some thoughts on this I didn't want to lose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants