Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly add async to Promise returning functions. #81

Closed
wants to merge 4 commits into from
Closed

Explicitly add async to Promise returning functions. #81

wants to merge 4 commits into from

Conversation

strazzere
Copy link
Contributor

Closes #79

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 100.00% // Head: 99.84% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (b42f0f0) compared to base (da7796b).
Patch coverage: 94.82% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #81      +/-   ##
===========================================
- Coverage   100.00%   99.84%   -0.16%     
===========================================
  Files            9        9              
  Lines         1949     1960      +11     
  Branches       269      269              
===========================================
+ Hits          1949     1957       +8     
- Misses           0        3       +3     
Impacted Files Coverage Δ
src/module.ts 97.08% <80.00%> (-2.92%) ⬇️
src/fastboot.ts 100.00% <100.00%> (ø)
src/heimdall.ts 100.00% <100.00%> (ø)
src/tool.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@strazzere strazzere closed this by deleting the head repository Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicityl specify async keyword for methods returning Promises
1 participant