Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source conda.sh in env.sh | More robust env.sh #1651

Closed
3 tasks done
abejgonzalez opened this issue Nov 6, 2023 · 0 comments · Fixed by #1653
Closed
3 tasks done

Source conda.sh in env.sh | More robust env.sh #1651

abejgonzalez opened this issue Nov 6, 2023 · 0 comments · Fixed by #1653
Labels

Comments

@abejgonzalez
Copy link
Contributor

Background Work

Chipyard Version and Hash

N/A

OS Setup

N/A

Other Setup

N/A

Current Behavior

Chipyard's env.sh sources the conda environment by running conda activate .... However, if source /home/eecs/abe.gonzalez/miniforge3/etc/profile.d/conda.sh (or it's equivalent) isn't set up in the shell it will error saying there is no conda command. Sometimes this is due to users having a non-interactive bash setup v.s. an interactive one. This can be solved by adding source /home/eecs/abe.gonzalez/miniforge3/etc/profile.d/conda.sh to the env.sh.

Additionally, when running build-setup.sh multiple times, the conda activate ... will be appended multiple times to the file causing slow env.sh source times. This can be solved by doing what conda does by having a the setup scripts check the env.sh file for specific sections and replacing them if they exist (instead of appending).

Expected Behavior

See above.

Other Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant