Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SynopsysTool and MentorTool belong in their respective cad-plugins repos #185

Closed
jwright6323 opened this issue Sep 7, 2018 · 4 comments
Closed
Labels
advanced PR low priority Easy workaround exists, regular QoL issue

Comments

@jwright6323
Copy link
Contributor

It probably makes sense to include the CadenceTool and SynopsysTool (and future InsertVendorTool) classes with their subclasses.

class CadenceTool(HasSDCSupport, HammerTool):

@edwardcwang
Copy link
Member

Related to #198

@colinschmidt colinschmidt added low priority Easy workaround exists, regular QoL issue advanced PR labels Dec 7, 2018
@harrisonliew
Copy link
Contributor

CadenceTool moved by #576 but SynopsysTool & MentorTool remain

@harrisonliew harrisonliew changed the title CadenceTool belongs in the cad-plugins repo SynopsysTool and MentorTool belong in their respective cad-plugins repos Jan 26, 2022
@harrisonliew
Copy link
Contributor

harrisonliew commented May 11, 2022

There needs to be a better mechanism for the respective plugin repos to import their common code. Currently, for Cadence tools, we have to do this:

sys.path.append(os.path.join(os.path.dirname(os.path.realpath(__file__)),"../../common"))
from tool import CadenceTool

@harrisonliew
Copy link
Contributor

Solved in #713 and packaging infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced PR low priority Easy workaround exists, regular QoL issue
Projects
None yet
Development

No branches or pull requests

4 participants