Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all registers list for simulations into separate json #574

Closed
colinschmidt opened this issue May 27, 2020 · 2 comments · Fixed by #576
Closed

Move all registers list for simulations into separate json #574

colinschmidt opened this issue May 27, 2020 · 2 comments · Fixed by #576

Comments

@colinschmidt
Copy link
Contributor

Rather than inlining this field, since it is often very large, we should have it be a separate file and the current key become a path to that file.
This should speed up hammer's launch when these json fragments are included.

@jwright6323
Copy link
Contributor

Does it even need to be a key? I thought you could just use multiple -p arguments to achieve the desired effect.

@colinschmidt
Copy link
Contributor Author

Right now this is tracked as part of the output of the syn and par actions and an input to the sim action.
You could move it outside of this tracking system but I don't think that is a good idea since the simulation will not run correctly without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants