Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starlette 0.35.0 contains breaking change involving BL_Python.web request logging #41

Closed
aholmes opened this issue Feb 16, 2024 · 0 comments · Fixed by #40
Closed

Starlette 0.35.0 contains breaking change involving BL_Python.web request logging #41

aholmes opened this issue Feb 16, 2024 · 0 comments · Fixed by #40
Assignees
@aholmes
Labels
bug Something isn't working

Comments

@aholmes
Copy link
Member

aholmes commented Feb 16, 2024 •
edited
Loading

Starlette 0.35.0 contains a breaking change. This change updates Starlette to use None for the test client, which is compliant with the ASGI spec, but breaks BL_Python.web. See encode/starlette#2377 (comment) for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aholmes aholmes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@aholmes