Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same ID documentation for use and sanitization #228

Open
yashpatel6 opened this issue Sep 9, 2024 · 0 comments
Open

Same ID documentation for use and sanitization #228

yashpatel6 opened this issue Sep 9, 2024 · 0 comments

Comments

@yashpatel6
Copy link
Collaborator 

          suggestion (non-blocking):
  • I think it would be helpful to have something in the Inputs section of the Readme that notes which fields will be sanitized and what that involves.
  • It would also be helpful to clarify...
    • For FASTQ input: the difference between sample and bam_header_sm
    • For BAM input: whether the output will use the input sample string or the sample ID from the input BAM readgroups.

Originally posted by @sorelfitzgibbon in #225 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yashpatel6