Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

357 - Add testing for other college field manipulation #358

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

Janell-Huyck
Copy link
Contributor

Fixes #357

We refactored the JavaScript and HTML for the Colleges list and Other College fields when creating a publication. This PR tests the functionality of those changes when applied to a new Artwork. Since all publication types are inheriting from the same partial, it is assumed that tests passing for one publication type will pass for all. This pr tests:

  • it 'selects an already listed college'
  • it 'toggles the Other College text field'
  • it 'allows user to select Other college without filling in the Other name'
  • it 'remembers the typed in Other College when the Other checkbox is unchecked'
  • it 'does not save a typed in Other College if the Other checkbox is unchecked'
  • it 'saves both a listed college and Other college when selected'

@scherztc scherztc merged commit 8201335 into qa Feb 1, 2024
2 checks passed
@scherztc scherztc deleted the 357-testing-other-college-form branch February 1, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase testing for Other College selections Javascript code
2 participants