389 - Enhance Test Stability with Improved Wait Mechanisms #390
Conversation
Janell-Huyck
changed the title
Janell-Huyck
changed the title
| expect(page).to have_selector("input[name='book[author_first_name][]']", visible: true) | ||
|
|
||
| expect(page).to have_content('Add Author') | ||
| expect(page).not_to have_content('Add Artist') |
There was a problem hiding this comment.
@Janell-Huyck You still have these checks for 'Add Author' and 'Add Artist' in several places in this file even though your new add_author_or_artist_and_verify_field method also checks for them. Can you safely get rid of these expects?
There was a problem hiding this comment.
Part of what I learned with this pr is that the statement expect(page).to have_selector("input[name='book[author_first_name][]']" has the side-effect of causing Capybara to wait until these elements are loaded before proceeding.
The problems I was having have to do with Capybara proceeding to check things before pages have actually loaded. The best way I found to slow Capybara down is to add these checks in before I check what I'm actually needing to check.
Are you aware of another way to do this? I have tried to sprinkle this check in anywhere where Capybara might have been expected to either initially load or to reload a page due to some server-side Javascript actions. It will wait up to the default_wait_time for these things to load, but if they're there it proceeds immediately.
There was a problem hiding this comment.
I was only referring to lines 62 & 63. They verify the "Add Author" or "Add Artist" buttons are there, but then right after that you call add_author_or_artist_and_verify_field, which does its own (second) check that "Add Author" or "Add Artist" are present.
So I'm wondering if expect(page).to have_content('Add Author') and expect(page).not_to have_content('Add Artist') are redundant because of add_author_or_artist_and_verify_field? Or are they needed to slow Capybara down?
There was a problem hiding this comment.
Ah, I see what you're saying. The helper method is checking that there's only one type of button, but it doesn't really care which one is there. This test here is more about making that the correct button type is present. The "book" model should have "author", and if it had "artist" that should fail. The add_author_or_artist_and_verify_field method will pass for either one.
There was a problem hiding this comment.
Rebasing... hang on
There was a problem hiding this comment.
Thanks for the explanation and the rebase. I'll merge when the build goes green. (might want to look into turning on parallel testing in CI)
Janell-Huyck
force-pushed
the
389-fix-flaky-author-management-tests
branch
from
71653bf
to
da1de1a
Compare
Fixes #389
Adds Improved Wait Mechanisms to Feature Tests
We were having issues with flaky tests due to the tests proceeding asynchronously, doing things like testing for conditions that happen after a button was clicked without waiting for the page to reload after the button click.
This PR includes using facotries and db checks to reduce unnecessary time spent mimicking screen clicking, and wait mechanisms to ensure feature tests more reliably wait for pages to fully load before proceeding.
This PR has run its CI tests 10 times without failing, so it should fix the test flakiness introduced in the spec/feature/author_management directory.