Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent logging of tile index #245

Closed
gcode-importer opened this issue Oct 8, 2013 · 5 comments
Closed

Inconsistent logging of tile index #245

gcode-importer opened this issue Oct 8, 2013 · 5 comments
Assignees
Milestone

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 245

Through the code the number of the currently being processed tiles was sometimes logged
as 0-based and sometimes as 1-based. Attached patch changes this to consistently use
1-based indexes in log messages.

Patch was created with diff based on OpenJPEG 2.0.0

Reported by brta.enfocus on 2013-10-08 12:36:50


- _Attachment: [consistent use of tile index in logging](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-245/comment-0/consistent use of tile index in logging)_
@gcode-importer
Copy link
Author

Could you please provide a unified diff patch (diff -ru). Your patch does not apply
for me over here:

$ patch --verbose -p1 --dry-run < /tmp/consistent\ use\ of\ tile\ index\ in\ logging

Hmm...  I can't seem to find a patch in there anywhere.
patch: **** Only garbage was found in the patch input.

Reported by malaterre on 2014-02-24 08:40:27

@gcode-importer
Copy link
Author

Reported by malaterre on 2014-02-25 15:56:10

  • Labels added: Milestone-Release2.1

@gcode-importer
Copy link
Author

marking as wontfix until OP update status. thanks.

Reported by malaterre on 2014-03-03 11:54:09

  • Status changed: WontFix

@gcode-importer
Copy link
Author

New patch created with command
diff -ru Patched/src/lib/openjp2/j2k.c Original/src/lib/openjp2/j2k.c > Issue245-Patch2.txt

Reported by brta.enfocus on 2014-07-07 10:03:58


- _Attachment: [Issue245-Patch2.txt](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-245/comment-4/Issue245-Patch2.txt)_

@gcode-importer
Copy link
Author

Reported by detonin on 2014-07-08 11:43:17

  • Status changed: Accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants