Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept CDK constructs in on_* methods. #146

Open
gshpychka opened this issue May 2, 2022 · 1 comment
Open

Accept CDK constructs in on_* methods. #146

gshpychka opened this issue May 2, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@gshpychka
Copy link

It would be great if we could pass a CDK construct in the on_* methods, instead of passing all the ARN parts. The boilerplate feels unnecessary.

@gshpychka gshpychka added the enhancement New feature or request label May 2, 2022
@udondan
Copy link
Owner

udondan commented May 3, 2022

It's a nice idea but I don't see a viable solution.

How would floyd know if a construct has an ARN and what is the properties name without manually implementing every available CDK construct?

Manually implementing every single construct seems to be a huge amount of work and the benefit is rather small, because passing an ARN is pretty straight forward, e.g. for a Lambda function: .on(fn.functionArn).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants