-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to .cjs for package.json main #196
Comments
Thanks! We decided to go with ECMAScript modules only. Read more about the reasoning here: Also, the linked comment has interesting insights, too: We know that this can causes issues in some setups (older Node versions, or Yarn pnp), but want to build a new package on a modern foundation. Maybe you can work around this in some way, for example with a separate project setup. |
I see, that make sense. I found how to patch the package using
|
Oh, that’s a great solution. Thanks for sharing! |
The problem I am facing
Yarn pnp is not compatible with ESM.
The solution I would like
Change package.json files like so:
Additional context
I couldn't open a PR (cannot push a branch or fork the repo). But I attach a diff for convenience. diff.txt
The text was updated successfully, but these errors were encountered: