Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Link pasting unexpected behavior change #4484

Open
1 of 2 tasks
segevfiner opened this issue Sep 28, 2023 · 4 comments
Open
1 of 2 tasks

[Bug]: Link pasting unexpected behavior change #4484

segevfiner opened this issue Sep 28, 2023 · 4 comments
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@segevfiner
Copy link
Contributor

segevfiner commented Sep 28, 2023

Which packages did you experience the bug in?

core, extension-link

What Tiptap version are you using?

2.1.11

What’s the bug you are facing?

Pasting a link on existing text used to add a link mark on the text while keeping the text, it now seems to replace the text with the link.

What browser are you using?

Chrome

Code example

https://tiptap.dev/api/marks/link

What did you expect to happen?

Pasting a link on selected text will just add a link mark on the selected text.

Anything to add? (optional)

This used to work in 2.0.4 and 2.1.10. It is caused by this change #4354

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@segevfiner segevfiner added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Sep 28, 2023
@github-project-automation github-project-automation bot moved this to Triage open in Tiptap Sep 28, 2023
@segevfiner
Copy link
Contributor Author

@bdbch

@segevfiner
Copy link
Contributor Author

Also, the paste handler that was removed seems to have regressed at some point in Tiptap 2.1, where if you paste in the middle of a line the link will be off, and it also adds an extra newline after a link.

@bdbch
Copy link
Member

bdbch commented Oct 10, 2023

Thanks, I'll take a look into it.

@andreasvirkus
Copy link

Seems to work correctly with 2.1.12 🎉

@bdbch bdbch mentioned this issue Dec 15, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

4 participants