[Bug]: @tiptap/extension-history update crashes #5258
Labels
Category: Open Source
The issue or pull reuqest is related to the open source packages of Tiptap.
Type: Bug
The issue or pullrequest is related to a bug
Comments
creatyvtype
added
Category: Open Source
|
Hello @creatyvtype! I'm not a maintainer but I'm happy to try to help you move this forward. Can you please share the results of the following (or equivalent for npm/pnpm.) It's possible you have multiple versions of packages installed after the upgrade. If that's not the case, can you please try to bisect where this began for you? Was it also broken in 2.2.x? 2.3.x? |
|
We are in a monorepo using rush and pnpm.
|
|
Feel free to hide the above.. it is a lot. I attempted the following with these results:
My deduction is that the prosemirror-history changes in that minor version are causing the issue. Either that or the way |
|
@creatyvtype hey mate I'm sure this will help you, had a similar issue #4704 (comment) |
|
@kashanghori thank you, but I'm not using starter kit. I'm only importing using the extension once. The one and only change that produces this bug is the upgrade of |
|
Fwiw I don't see this issue with the history extension on the same version. I assume you already tried disabling your other extensions? |
|
@Nantris I did not. Would you want me to do that for debugging purposes? Our product will still require the other extensions. Do you know of other extensions that also use history under the hood in some way? |
|
There can be unexpected interactions between the extensions at times. I don't know that commenting out your other extensions will give you any clues, but that's the next thing I'd try. Dozens of times I've gotten weird bugs and found some obscure interaction in the extensions causing it which I'd never have expected just reasoning through the situation. |
|
If you are using collaboration, history needs to be disabled. If you have an issue with prosemirror-history I recommend going upstream instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected Packages
@tiptap/extension-history
Version(s)
2.4.0
Bug Description
We were on 2.1.16, and in updating to 2.4.0, we started seeing an error specifically when using our history option.
The error:
This issue appears to be coming from the underlying
prosemirror-history. By downgrading that package from1.4.0which is what it resolved from to1.3.0which was where it was in the last version, the error goes away.I recognize this is likely a prosemirror issue, but as we are getting the version via tiptap, I would hope the fix comes from here.
Thank you!
Browser Used
Chrome
Code Example URL
No response
Expected Behavior
Expect the history module to work as usual.
Additional Context (Optional)
No response
Dependency Updates
The text was updated successfully, but these errors were encountered: