-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in weightgen for C48 grids #1005
Comments
@ClaraDraper-NOAA - I think the '94' dimension may be intentional. C48 is being mapped to the old spectral GFS T62 gaussian grid, which is defined here: https://www.nco.ncep.noaa.gov/pmb/docs/on388/tableb.html#GRID98. Note the 192x94 dimension. |
Interesting! Do you know if all Gaussian C48 output is expected to be on the T62 grid (as in, the GFS output history files, and the GSI increments/DA)? The issue I have at the moment is that the enkf is outputting increments files for C48 that are 192x96, and the latitudes in that file do not include the poles (conflicting with the above). So, I'm wondering if: |
I would have thought that everyone would use the standard T62 grid. I hate to update a grid definition that others may be using. If the grids for the various processes can't be unified, I would be happy to add a new option (call it "C48da"?) with the dimensions you need. |
Let me look into what's happening on the DA side, before we decide how to handle it. It may be as simple as the lats in the output file aren't right. Do you want to close this issue for now? |
Let's keep it open for now. I am looking through the 'fix' directory, I see some T94 files with dimensions of 192x96. For example: |
Sounds good. I should be able to get to it before the end of this week. |
I see what you mean - both the T94 and T64 options are there. For C48, the forecast history files are output at T94, and the DA is done at that resolution. I need to do more digging to understand how the dimensions are set though. |
Summarizing our discussion: the code is OK as is, but would be made clearer by changing this line:
to something like:
|
Some of the other gaussian grids correspond to NCEP standard grids. That would be worth noting as well. Let me do some quick research. |
Here is what I found that would be worth noting in comments:
|
The dimension for C48 Gaussian files is incorrect.
Here, 2x48 is 96, not 94.
UFS_UTILS/sorc/weight_gen.fd/scrip.F90
Line 55 in 5e1138e
We need to change jdim to 96 and jdimp to 98. Same for the char variables.
The text was updated successfully, but these errors were encountered: