Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EARTH_GRID_COMP should be named UFSDriver #1017

Closed
rsdunlapiv opened this issue Jan 23, 2022 · 3 comments · Fixed by #1239
Closed

EARTH_GRID_COMP should be named UFSDriver #1017

rsdunlapiv opened this issue Jan 23, 2022 · 3 comments · Fixed by #1239
Labels
bug Something isn't working

Comments

@rsdunlapiv
Copy link

Description

In ESMF, "gridded components" or "gridcomps" are plain ESMF components (no NUOPC). The UFS Driver is a NUOPC Driver, and so the term "EARTH_GRID_COMP" is not as precise as it could be, and does not communicate that the top-level component has NUOPC interfaces.

This goes along with recent efforts to remove the NEMS repository and clean up the fv3 cap.

Some possibilities for this name:

  • UFSDriver
  • UFS_Driver
  • UFSEarthDriver
@rsdunlapiv rsdunlapiv added the bug Something isn't working label Jan 23, 2022
@rsdunlapiv
Copy link
Author

relates to #998

@arunchawla-NOAA
Copy link

@rsdunlapiv is this really a bug ? or a discussion ?

@junwang-noaa
Copy link
Collaborator

We discussed this issue, we will go with the name UFSDriver.

@DusanJovic-NOAA DusanJovic-NOAA mentioned this issue Jun 1, 2022
Merged
17 tasks
@junwang-noaa junwang-noaa mentioned this issue Jun 1, 2022
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@rsdunlapiv @junwang-noaa @arunchawla-NOAA