Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum version requirement for ESMF #1162

Closed
tsupinie opened this issue Apr 7, 2022 · 1 comment · Fixed by #1239
Closed

Minimum version requirement for ESMF #1162

tsupinie opened this issue Apr 7, 2022 · 1 comment · Fixed by #1239
Labels
bug Something isn't working

Comments

@tsupinie
Copy link

tsupinie commented Apr 7, 2022

Description

In the configure step, there is no version requirement for ESMF. However, the model requires the latest version of ESMF (v8.2.0). This causes an error when compiling with a lower version.

To Reproduce:

I'm using Intel compilers on TACC Frontera, but it should be platform- and compiler-independent.

  1. Attempt to compile with ESMF v8.1.0 or lower.
  2. Notice the following compile error:

Screen Shot 2022-04-07 at 16 43 43

That happens because the configFileName argument is ESMF v8.2.0-only.

Fix

The fix is to add v8.2.0 as a minimum requirement for ESMF in the root CMakeLists.txt. I can submit a PR, or y'all can do it; it's literally a one-line fix.

@tsupinie tsupinie added the bug Something isn't working label Apr 7, 2022
@junwang-noaa
Copy link
Collaborator

junwang-noaa commented May 23, 2022

@tsupinie we had some discussion on this issue. The plan is to use the minimum version number for all the libraries. But we'd like to clarify that ESMF beta snapshots (e.g. v8.3.0b09) have been used in ufs-weather-model, and the CMakeLists.txt can not interpret it correctly at this time. So setting ESMF minimum version number may not catch all the ESMF version issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants