-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow shared parallelio #1512
Comments
George V. also had problem with the parallelio when building UFS on gaea C5. @DusanJovic-NOAA would you please take a look at this issue? Thanks |
I would very much like the |
I agree . Remove STATIC. |
@AlexanderRichert-NOAA can you remove "STATIC" for parallelio in CMakeLists.txt and test it in ufs wm? We prefer to use "STATIC" for operational code, but let's see if this resolve the issue. |
Yes-- it can be removed with a sufficiently recent copy of the CMakeModules submodule, which has a version of FindPIO.cmake that supports the shared library (and without needing to specify shared vs. static in CMakeLists.txt). |
Has this been done so I can build with shared PIO? |
@GeorgeVandenberghe-NOAA Not yet. Once the CMakeModules submodule gets updated, then this change will be possible. If you want to make the change in your own installation, then just replace CMakeModules with the latest version, then remove the "STATIC" component from PIO in CMakeLists.txt. |
Description
CMakeLists.txt hardcodes parallelio as a STATIC library. For flexibility and consistency with the way other libraries are used which allows either static or shared, can this be changed to allow for the shared version of PIO?
Solution
Sufficiently recent versions of CMakeModules support shared PIO, at which point the PIO "STATIC" keyword in CMakeLists.txt can be removed.
The text was updated successfully, but these errors were encountered: