Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEDI_SEMI incorrectly halves DT_ATMOS in tests/default_vars.sh #2496

Open
NickSzapiro-NOAA opened this issue Nov 14, 2024 · 1 comment · May be fixed by #2543
Open

SEDI_SEMI incorrectly halves DT_ATMOS in tests/default_vars.sh #2496

NickSzapiro-NOAA opened this issue Nov 14, 2024 · 1 comment · May be fixed by #2543
Assignees
Labels
bug Something isn't working

Comments

@NickSzapiro-NOAA
Copy link
Collaborator

Description

Currently in default_vars.sh#L1178:
if [[ ${SEDI_SEMI} = .true. ]]; then export DT_ATMOS=$((DT_ATMOS/2)); fi

Presumably, semi-Lagrangian method should have a longer timestep, not shorter.
This also conflicts with what's in global-workflow config.fcst#L210-L212

export dt_inner=$((DELTIM/2))
export sedi_semi=.true.
if [[ "${sedi_semi}" == .true. ]]; then export dt_inner=${DELTIM} ; fi

In default_vars, maybe the corresponding implementation is:
if [[ ${SEDI_SEMI} = .false. ]]; then export DT_INNER=$((DT_ATMOS/2)); fi

This bug would increase test wallclock for tests calling export_ugwpv1() @dpsarmie @BrianCurtis-NOAA @DeniseWorthen @junwang-noaa @jkbk2004
Any adjusted k_split, n_split we're running should be revisited too

@NickSzapiro-NOAA NickSzapiro-NOAA added the bug Something isn't working label Nov 14, 2024
@DeniseWorthen
Copy link
Collaborator

I noticed a secondary issue w/rt the DT settings. WW3 gets it's timestep length from the binary mod_def file. When WW3 is in the fast loop, if ATM and ICE are at 360 (like now), WAV is still at 720.

I'm really not sure we're doing in that case....WAV will integrate to the end of it's global (dtmax) timestep, which is 720 and won't return from the model Advance until then. But ATM and ICE are trying to chug along at DT 360, sending fields at that frequency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants