Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional restart run is creating different results. #408

Closed
RatkoVasic-NOAA opened this issue Feb 4, 2021 · 8 comments
Closed

Regional restart run is creating different results. #408

RatkoVasic-NOAA opened this issue Feb 4, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@RatkoVasic-NOAA
Copy link
Collaborator

Description

Regional restart regression test is comparing results to itself, and not to control run.
For global application all is OK,

To Reproduce:

I used regression test to create CONTROL and RESTART work directories and repeated runs using quilting=trrue
phyf*** and dynf*** files differed between the two runs.

Additional context

Output

Screenshots

output logs


@RatkoVasic-NOAA RatkoVasic-NOAA added the bug Something isn't working label Feb 4, 2021
@junwang-noaa
Copy link
Collaborator

@JacobCarley-NOAA May I ask who may work on this issue?

@jwolff-ncar
Copy link
Collaborator

Was this resolved with @DomHeinzeller's commit (#417) or is there still an outstanding issue? (I think this may only be in the release branch at this time.)

@climbfuji
Copy link
Collaborator

Was this resolved with @DomHeinzeller's commit (#417) or is there still an outstanding issue? (I think this may only be in the release branch at this time.)

This was resolved for the release/public-v2 branch, and the only changes I had to make were (a) code that was added to develop between July 2020 (when the release branch was cut) and December 2020 (from Moorthi and Shan), and (b) NoahMP-specific code changes (these are not yet in develop).

@junwang-noaa
Copy link
Collaborator

@climbfuji I see the restart reproducibility tests in release/public-v2 are for suite files FV3_GFS_v15p2 and FV3_RRFS_v1alpha. While the regional LAM tests are using FV3_GFS_v15_thompson_mynn, and the restart test does not reproduce the control with this suite file. So the release/public-v2 does not support FV3_GFS_v15_thompson_mynn?

@climbfuji
Copy link
Collaborator

It doesn't support it officially, but it will give b4b reproducible results if you add the suite manually and compile it.

@junwang-noaa
Copy link
Collaborator

I tested the latest develop branch, the restart test using FV3_GFS_v15_thompson_mynn do not reproduce from control. Do you mean the release/public-v2 has restart reproducibility for FV3_GFS_v15_thompson_mynn?

@climbfuji
Copy link
Collaborator

I tested the latest develop branch, the restart test using FV3_GFS_v15_thompson_mynn do not reproduce from control. Do you mean the release/public-v2 has restart reproducibility for FV3_GFS_v15_thompson_mynn?

Yes, 99% confident that it has. But according to Lucas Harris, we shouldn't bring over all these changes 1:1, but fix the regional boundary update script and then remove any unnecessary mpp_update_domain calls in the dycore. I am happy to assist or lead this effort, but not this week.

@junwang-noaa
Copy link
Collaborator

The issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants