Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create parent directories in file copy mode #485

Merged
merged 11 commits into from
May 15, 2024
Merged

Create parent directories in file copy mode #485

merged 11 commits into from
May 15, 2024

Conversation

maddenp-noaa
Copy link
Collaborator

@maddenp-noaa maddenp-noaa commented May 13, 2024 •
edited
Loading

Synopsis

Fix a bug whereby uw file copy would not create nested parent directories, and add unit tests against regressions. Fixes #484.

Type

  • Bug fix (corrects a known issue)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this May 13, 2024
@maddenp-noaa maddenp-noaa marked this pull request as ready for review May 14, 2024 20:04
NaureenBharwaniNOAA
NaureenBharwaniNOAA approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@maddenp-noaa maddenp-noaa merged commit fc0ca6f into ufs-community:main May 15, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the gh-issue-484-file-copy-parent-dirs branch May 15, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr

@WeirAE WeirAE Awaiting requested review from WeirAE

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uwtools.api.file.copy cannot create nested directories
3 participants
@maddenp-noaa @NaureenBharwaniNOAA @elcarpenterNOAA