Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In fs mode, replace KEY positional arguments with --key-path #668

Closed
5 tasks
maddenp-noaa opened this issue Dec 7, 2024 · 0 comments · Fixed by #670
Closed
5 tasks

In fs mode, replace KEY positional arguments with --key-path #668

maddenp-noaa opened this issue Dec 7, 2024 · 0 comments · Fixed by #670
Assignees

Comments

@maddenp-noaa
Copy link
Collaborator

maddenp-noaa commented Dec 7, 2024

Description

Currently the fs actions copy, link, and makedirs take an arbitrary number of positional KEY arguments on the CLI, and an optional keys API argument, to specify a keypath leading to the config block to use. This should be harmonized with the rest of uwtools to use CLI --key-path and API key_path, with matching semantics.

AC

  • CLI is updated to use --key-path.
  • API is updated to use key_path.
  • Documentation is updated.
  • Unit tests are updated.
  • Jupyter notebooks are updated (if needed).
@maddenp-noaa maddenp-noaa converted this from a draft issue Dec 7, 2024
@christinaholtNOAA christinaholtNOAA moved this from Backlog to Todo in Unified Workflow Kanban Dec 9, 2024
@maddenp-noaa maddenp-noaa moved this from Todo to In Progress in Unified Workflow Kanban Dec 9, 2024
@maddenp-noaa maddenp-noaa moved this from In Progress to Peer Review in Unified Workflow Kanban Dec 9, 2024
@maddenp-noaa maddenp-noaa self-assigned this Dec 9, 2024
@maddenp-noaa maddenp-noaa moved this from Peer Review to Done in Unified Workflow Kanban Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant